build(deps): bump maven-plugin-annotations from 3.4 to 3.6.1 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [maven-plugin-annotations](https://github.com/apache/maven-plugin-tools) from 3.4 to 3.6.1. - [Release notes](https://github.com/apache/maven-plugin-tools/releases) - [Commits](apache/maven-plugin-tools@maven-plugin-tools-3.4...maven-plugin-tools-3.6.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugin-tools:maven-plugin-annotations dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
There was a problem hiding this comment.
@joschi I suggest that we add these dependencies to a Dependabot ignore.
Given that we've scoped maven-core, maven-plugin-api, and maven-plugin-annotations as provided, we're expecting the user's maven to provide the dependency at runtime. If we upgraded these dependencies, we'd be allowing ourselves to use features that may not be present in the user's maven client version, which causes a safety issue.
|
@misterjoshua Yes, this makes sense. Would you please add them to the Dependabot ignore list? EDIT: I've created #290, review appreciated. 😄 |
joschi
added a commit
that referenced
this pull request
Nov 21, 2021
joschi
added a commit
that referenced
this pull request
Nov 21, 2021
joschi
added a commit
that referenced
this pull request
Nov 21, 2021
|
Looks like org.apache.maven.plugin-tools:maven-plugin-annotations is no longer being updated by Dependabot, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/maven/org.apache.maven.plugin-tools-maven-plugin-annotations-3.6.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps maven-plugin-annotations from 3.4 to 3.6.1.
Commits
a6e2a96[maven-release-plugin] prepare release maven-plugin-tools-3.6.1f727d26Update plugins129217bClean up plugins620b085Clean up coded3e52d0[MPLUGIN-348] Why does maven-plugin-plugin always warn if goalPrefix is set?5417a1c[MPLUGIN-365] Don't log a warning when packaging type unsupported -> info is ...e477e6c[MPLUGIN-360] generated plugin-help.xml ignores descriptor mojo outputDirectory2f29e9a[MPLUGIN-369] - Upgrade ASM Api version to ASM9 in visitors - in sync with th...9d1289e[MPLUGIN-367] Improve@Execute(lifecycle...) docs (#30)f574628[MPLUGIN-368] Improve@Execute(goal...) docs (#31)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)