Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Git hook repository check to enable build without .git #301

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Dec 12, 2021

The build process would fail if the .git/ directory is missing, e. g. when downloading the repository contents from GitHub in a ZIP archive:

[ERROR] Failed to execute goal io.github.phillipuniverse:githook-maven-plugin:1.0.5:install (default) on project openapi-diff-parent: Not a git repository, could not find a .git/hooks directory anywhere in the hierarchy of /path/to/openapi-diff/target. Turn off this behavior with skipRepositoryCheck=false -> [Help 1]

After the change, a missing .git/ directory doesn't lead to a build failure:

[INFO] --- githook-maven-plugin:1.0.5:install (default) @ openapi-diff-parent ---
[INFO] No .git directory found, skipping plugin execution

Refs #299

@joschi joschi added the bug label Dec 12, 2021
@joschi joschi added this to the 2.0.1 milestone Dec 12, 2021
@joschi joschi self-assigned this Dec 12, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joschi joschi merged commit d2a96f1 into master Dec 12, 2021
@joschi joschi deleted the githook-skip-repo-check branch December 12, 2021 14:08
@joschi joschi linked an issue Dec 27, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using maven plugin prevents building from tarball
1 participant