Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][typescript-angular] Type mapping from DateTime to string causes build error #4330

Closed
mmajrk opened this issue Oct 30, 2019 · 3 comments · Fixed by #4337
Closed

[BUG][typescript-angular] Type mapping from DateTime to string causes build error #4330

mmajrk opened this issue Oct 30, 2019 · 3 comments · Fixed by #4337

Comments

@mmajrk
Copy link
Contributor

mmajrk commented Oct 30, 2019

I encountered the same issue on v 4.1.3 as described here:
#2745

When using a type mapping from DateTime to string, generated code contains lines such as queryParameters = queryParameters.set('dateFrom', <any>dateFrom.toISOString());, which causes build failure.

This was fixed for typescript-axios generator, but the issue is still present in typescript-angular. I'd like to open a PR with a fix.

@auto-labeler
Copy link

auto-labeler bot commented Oct 30, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@mmajrk mmajrk changed the title [typescript-angular] Type mapping from DateTime to string causes build error [BUG][typescript-angular] Type mapping from DateTime to string causes build error Oct 30, 2019
@mmajrk
Copy link
Contributor Author

mmajrk commented Oct 30, 2019

I'm not familiar with the codebase, would it be ok to override DefaultCodegen.fromProperty in AbstractTypeScriptClientCodegen.java? Or is it better to perform a runtime type check in the template as in #3423?

@Override
public CodegenProperty fromProperty(String name, Schema p) {
    CodegenProperty property = super.fromProperty(name, p);
    if (property.isDateTime && (property.dataType == "string" || property.dataType == "String")) {
        property.isString = true;
        property.isDateTime = false;
    }
    return property;
}

@macjohnny
Copy link
Member

I think a runtime check is better

mmajrk pushed a commit to mmajrk/openapi-generator that referenced this issue Oct 31, 2019
jimschubert added a commit that referenced this issue Nov 3, 2019
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits)
  smaller tests, better code format (#4355)
  csharp-netcore: Replace null literals with default (#4345)
  [core] consider polymorphism when computing unused schemas (#4335)
  Fix issue 4326 forward throws for delegate to main method (#4327)
  [kotlin][client] annotate api exceptions (#4339)
  refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
  Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
  [python][metadata]: Adding license and author fields (#4318)
  [Python] Avoid pep8 violation (#4316)
  [JS] Update package.json (#4261)
  Add slash-arun to Python technical committee (#4354)
  [typescript-fetch] Fix discriminator mapping name (#4340)
  fix security alerts reported by github (#4344)
  fix cpp-restbed-server json field serialization #4320 (#4323)
  typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
  fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
  update samples (#4334)
  Prepare 4.2.0 release (#4333)
  [FEATURE][Haskell] Haskell-Servant serves static files (#4058)
  [FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
  ...
jimschubert added a commit that referenced this issue Nov 3, 2019
* master: (142 commits)
  smaller tests, better code format (#4355)
  csharp-netcore: Replace null literals with default (#4345)
  [core] consider polymorphism when computing unused schemas (#4335)
  Fix issue 4326 forward throws for delegate to main method (#4327)
  [kotlin][client] annotate api exceptions (#4339)
  refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
  Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
  [python][metadata]: Adding license and author fields (#4318)
  [Python] Avoid pep8 violation (#4316)
  [JS] Update package.json (#4261)
  Add slash-arun to Python technical committee (#4354)
  [typescript-fetch] Fix discriminator mapping name (#4340)
  fix security alerts reported by github (#4344)
  fix cpp-restbed-server json field serialization #4320 (#4323)
  typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
  fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
  update samples (#4334)
  Prepare 4.2.0 release (#4333)
  [FEATURE][Haskell] Haskell-Servant serves static files (#4058)
  [FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
  ...
jimschubert added a commit to jimschubert/openapi-generator that referenced this issue Nov 3, 2019
* master: (141 commits)
  smaller tests, better code format (OpenAPITools#4355)
  csharp-netcore: Replace null literals with default (OpenAPITools#4345)
  [core] consider polymorphism when computing unused schemas (OpenAPITools#4335)
  Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327)
  [kotlin][client] annotate api exceptions (OpenAPITools#4339)
  refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353)
  Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352)
  [python][metadata]: Adding license and author fields (OpenAPITools#4318)
  [Python] Avoid pep8 violation (OpenAPITools#4316)
  [JS] Update package.json (OpenAPITools#4261)
  Add slash-arun to Python technical committee (OpenAPITools#4354)
  [typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340)
  fix security alerts reported by github (OpenAPITools#4344)
  fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323)
  typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341)
  fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337)
  update samples (OpenAPITools#4334)
  Prepare 4.2.0 release (OpenAPITools#4333)
  [FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058)
  [FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056)
  ...
Xambey pushed a commit to Xambey/openapi-generator that referenced this issue Dec 14, 2019
macjohnny pushed a commit that referenced this issue Dec 18, 2019
…me (#4623 #4763) (#4792)

* fix(typescript-angular): Fix date-timing-parsing is truncating the time

* fix(typescript-angular): Fix date-timing-parsing is truncating the time (#4330)

* fix(typescript-angular): Fix date-timing-parsing is truncating the time (#4623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants