Remove deprecated methods in default codegen #1031
Conversation
|
https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/2928/1/console
Oh, shippable has failed. 👀 |
|
From a Java-API point of view (for people having their own generator) this is a breaking change without fallback. I suggest to target 4.0 for a change like this one. cc: @jimschubert |
|
@jmini agreed with you. The user using a customized generator will need to do something in order to make it work after upgrading to 3.3.0 if we decide to merge the PR into master. I don't mind targeting this change for 4.0.x instead. |
|
@ackintosh I think that's because shippable merged origin/master into this branch. I'll merge master or 4.0.x into this branch later after we have a decision on which branch to target. |
* add oneOf support to Ruby
* add anyOf support to ruby client
* add discriminator support to ruby client
* fix typo
* update samples, fix NPE
* better format in ruby generator
* fix test cases, disable mapping test
* fix update script, update samples
* add test, fix mapping
* update exit code
* reenabled discriminator test
* remove duplicated properties
* add test for duplicated properties
* update samples, add new spec
* fix ruby test cases
* fix hasMore after removing duplicates
* refactor method, comment out haskell client test
* fix hasMore and update samples
* fix parent detection
* fix discriminator check
* [haskell-http-client] need to use {{vars}}{{required}} instead of {{requiredVars}}
* remove deprecated methods in default codegen (#1031)
* regenerate samples
* remove commented code
* add oneOf support to Ruby
* add anyOf support to ruby client
* add discriminator support to ruby client
* fix typo
* update samples, fix NPE
* better format in ruby generator
* fix test cases, disable mapping test
* fix update script, update samples
* add test, fix mapping
* update exit code
* reenabled discriminator test
* remove duplicated properties
* add test for duplicated properties
* update samples, add new spec
* fix ruby test cases
* fix hasMore after removing duplicates
* refactor method, comment out haskell client test
* fix hasMore and update samples
* fix parent detection
* fix discriminator check
* [haskell-http-client] need to use {{vars}}{{required}} instead of {{requiredVars}}
* remove deprecated methods in default codegen (OpenAPITools#1031)
* regenerate samples
* remove commented code
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
A follow-up PR to #859.