[elm] Major refactoring; add discriminator support#1104
Merged
eriktim merged 1 commit intoOpenAPITools:masterfrom Sep 29, 2018
Merged
[elm] Major refactoring; add discriminator support#1104eriktim merged 1 commit intoOpenAPITools:masterfrom
eriktim merged 1 commit intoOpenAPITools:masterfrom
Conversation
* Use the same name for all exposed encoder & decoders; * Improve imports (limit exposures); * Add support for OAS3 discriminators; * Distinct between 0.18 & latest mustache files.
4 tasks
Member
@trenneman no problem. I'll have a look tomorrow and let you know if I've any question. |
wing328
approved these changes
Sep 29, 2018
Member
wing328
left a comment
wing328
left a comment
There was a problem hiding this comment.
I'm ok with the change and would suggest adding Petstore integration tests later with the Elm petstore client.
Contributor
Author
|
Thanks @wing328 . I've already started working on that. Will create a PR to track its progress. |
Member
|
@trenneman this enhancement is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Use the same name for all exposed encoder & decoders; * Improve imports (limit exposures); * Add support for OAS3 discriminators; * Distinct between 0.18 & latest mustache files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
@wing328 Sorry this PR has become rather large.
-->
module Cat exposing (Cat, catDecoder, catEncoder)now becomesmodule Cat exposing (Cat, decoder, encoder);-->
import Data.Cat exposing (Cat, catDecoder, catEncoder)now becomesimport Data.Cat as Cat exposing (Cat), and henceCat.decoderis used instead ofcatDecoder;--> You can now use discriminators to make custom types like
Pet = CatType Cat | DogType Dog;