Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin][client] create comment to warn about android api version #11830

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Mar 8, 2022

When using kotlin client in Android, we should warn the users about the flag supportAndroidApiLevel25AndBelow to that they make an informed decision

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@4brunu 4brunu requested a review from wing328 March 8, 2022 10:24
@wing328 wing328 added this to the 6.0.0 milestone Mar 8, 2022
@wing328 wing328 merged commit 00ef435 into OpenAPITools:master Mar 8, 2022
@wing328
Copy link
Member

wing328 commented Mar 8, 2022

@4brunu thanks for the PR, which has been merged. Shall we mark this option as deprecated and remove it in 6.x release in the future?

(e.g. we've dropped JDK7 support in the Java client, server generators in the upcoming v6.0.0 release)

@4brunu 4brunu deleted the feature/kotlin-warning-android-api-version branch March 8, 2022 16:05
@4brunu
Copy link
Contributor Author

4brunu commented Mar 8, 2022

Hi @wing328, I think we shouldn't do it, because Android API level 25 and below is still used by a lot of devices.
I think we should support at least Android 21 and above.
So I think we should keep this.

@wing328
Copy link
Member

wing328 commented Mar 8, 2022

👌

Maybe mark it as deprecated in 6.0.0 release (manage expectation low) and schedule the removal in 7.0.0 release a year later. I'll let you decide.

@4brunu
Copy link
Contributor Author

4brunu commented Mar 8, 2022

Honestly I think we should keep it for a few years, because Android adoption moves very slowly.
For you to have an idea, last week I checked analytics in one client of mine, Android API Level 23 that was released in 2015, was the third most used Android version.

@wing328
Copy link
Member

wing328 commented Mar 8, 2022

Ah ok. Let's keep it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants