[elm] Add support for additionalProperties (map/hash/dictionary)#1262
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Oct 23, 2018
Merged
[elm] Add support for additionalProperties (map/hash/dictionary)#1262wing328 merged 1 commit intoOpenAPITools:masterfrom
additionalProperties (map/hash/dictionary)#1262wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
c4ff359 to
3e24a7c
Compare
Contributor
Author
|
@wing328 updated as discussed |
Member
|
@trenneman thanks. The change looks good to me. As discussed the top level "additionalProperties" should be treated as an alias instead of a separate model. We'll address that in a separate PR. |
additionalPropertiesadditionalProperties (map/hash/dictionary)
Contributor
|
Tested it, looking good :) Is there documentation somewhere to know that |
Contributor
Author
|
Have a look at https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/elm.md or the other generators in that directory. |
Contributor
|
Thanks :) |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1140.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Add support for
additionalPropertiesadditionalPropertiesin the parent alias? When I run the example from [elm] failed to generate map from object with additionalProperties #1140,alertalready contains the map andlabelSetbecomes obsolete.