Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaultValue for String schema in Dart #1342

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Fix defaultValue for String schema in Dart #1342

merged 1 commit into from
Nov 1, 2018

Conversation

ysawa
Copy link
Contributor

@ysawa ysawa commented Oct 30, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Output defaultValue value for String is unquoted and it will cause syntax errors in Dart.

Markdown outputs is like:

# openapi.model.CharacterDetail

## Properties
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**name** | **String** |  | [default to null]
**description** | **String** |  | [optional] [default to ]

and, **description** | **String** | | [optional] [default to ""] may be better.

Also, generated Dart code is as below:

class CharacterDetail {

  String name = null;

  String description = ;

, and this should be String description = "";.

I hope it will be fixed.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09)

@wing328
Copy link
Member

wing328 commented Oct 31, 2018

@ysawa thanks for the fix, which looks good to me. If no further feedback or question, I'll merge it tomorrow (Thursday)

@ysawa ysawa changed the title Fix defaultValue for String schama in Dart Fix defaultValue for String schema in Dart Oct 31, 2018
@ysawa
Copy link
Contributor Author

ysawa commented Oct 31, 2018

@wing328 thanks for your review. I am looking forward to the merge.

@wing328 wing328 merged commit 521f5fa into OpenAPITools:master Nov 1, 2018
@wing328
Copy link
Member

wing328 commented Nov 1, 2018

@ysawa PR merged into master. Thanks for your contribution.

Do you mind filing the same fix for Dart Jaguar client generator: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/DartJaguarClientCodegen.java#L64 ?

cc @jaumard

@wing328 wing328 added this to the 3.3.3 milestone Nov 14, 2018
@wing328
Copy link
Member

wing328 commented Nov 15, 2018

@ysawa thanks again for the PR, which has been included in the v3.3.3 release: https://twitter.com/oas_generator/status/1062929948191510528

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants