[C++][Pistache] Add some missing {{declspec}} on classes and functions #14808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
{{declspec}}
annotations were not consistently applied and were missing on some classes and free functions.Side note: the
declspec
anddefaultInclude
config options are not officially documented for the cpp-pistache-server generator, but they work correctly (aside the missing annotations). Not sure if something needs to be done on that front.My use case is that I'm building my server and APIs in a shared library and while trying to use the model classes in my tests couldn't link to it since some of the model symbols (
to_json
andfrom_json
in my case) were not exported (I'm usingdeclspec
anddefaultInclude
for the classical use case of exporting symbols).PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)cc @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd