[JAVA][SPRING] add imports & primitives to reserved words#16713
Open
martin-mfg wants to merge 2 commits intoOpenAPITools:8.0.xfrom
Open
[JAVA][SPRING] add imports & primitives to reserved words#16713martin-mfg wants to merge 2 commits intoOpenAPITools:8.0.xfrom
martin-mfg wants to merge 2 commits intoOpenAPITools:8.0.xfrom
Conversation
2cf7c3f to
77b2d6b
Compare
0c28291 to
222c665
Compare
5 tasks
Contributor
Author
|
Hi @wing328, may I suggest adding this PR to https://github.com/OpenAPITools/openapi-generator/milestone/54 ? Just so it's not forgotten for the next major release. Unless you prefer not to include this in 8.0.0? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Java-based generators, add
importMapping().keySet()andlanguageSpecificPrimitives()toreservedWords.Because using words from those two lists as class names or variable names causes problems in certain cases.
This is a follow-up to #16276 (comment) . However, after deeper investigation, I deviated a bit from the approach that I originally proposed there.
The addition of more reserved words leads to some variables in the samples code being renamed, e.g.
_integerand_dateTime. These didn't cause problems before the renaming actually, because the lowercase variable name "dateTime" doesn't clash with the uppercase class name "DateTime" anyway. But the current reserved words logic (of Java based generators) is case-independend and applies equally to variable names and class names. So in the current setup we can't avoid those unnecessary renamings I think. If you have an idea how to improve this situation, let me know.Since this slightly changes some public method names in the generated code, I targeted this PR at the 8.0.x branch.
example:
Regarding the failing java-camel test, please see #18870 (comment) .
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)