Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scala-sttp4: fix for missing EnumNameSerializer for inner enum definitions #18160

Merged
merged 1 commit into from
Mar 21, 2024
Merged

scala-sttp4: fix for missing EnumNameSerializer for inner enum definitions #18160

merged 1 commit into from
Mar 21, 2024

Conversation

dwischolek-modulon
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:

Fix for issue #18145

@wing328

@wing328
Copy link
Member

wing328 commented Mar 20, 2024

thanks for the PR.

cc @flsh86

flsh86
flsh86 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@flsh86 flsh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit bf2a251 into OpenAPITools:master Mar 21, 2024
24 checks passed
zapodot pushed a commit to zapodot/openapi-generator that referenced this pull request Mar 21, 2024
@dwischolek-modulon @zapodot
scala-sttp4: fix for missing EnumNameSerializer for inner enum defini…
4537c49 
…tions (OpenAPITools#18145) (OpenAPITools#18160)
@dwischolek-modulon dwischolek-modulon deleted the sttp4-fix-for-missing-enumnameserializer branch March 21, 2024 15:07
@wing328 wing328 added this to the 7.5.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flsh86 flsh86 flsh86 approved these changes

Assignees
No one assigned
Labels
Client: Scala Feature: Enum Issue: Bug
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dwischolek-modulon @wing328 @flsh86