-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spring] Add apiFirst option #184
Conversation
cc @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) |
ffc9c88
to
9c4c594
Compare
Are you sure that you did it? There is an error on Shippable
With this log:
The procedure should be, on your PR branch:
Can you try it (I did not investigate it myself yet). |
@jmini No I'm sure I updated the samples. Can you have a look on your side ? I suspect code generated might be different depending on the machine on which the generator is run. |
Same here. I do not have any changes.
Gives me this output:
For investigation, can you maybe add a line with openapi-generator/bin/ensure-up-to-date Lines 29 to 34 in 7dfd940
This way we will see what is going on, on the CI Server. |
So the code generation is indeed not fully predictable. See the shippable log. Not sure what to do from there... |
bin/ensure-up-to-date
Outdated
@@ -26,7 +26,9 @@ sleep 5 | |||
./bin/openapi3/php-petstore.sh | |||
|
|||
# Check: | |||
echo "Perform git diff" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have let this 3 lines (echo
, git diff
and git status
) inside the if... We do not need them in the OK case.
Thank you for the addition. Not having stable serialization is really bad. I guess In the mean time, I suggest that we remove spring from the list of checked samples. Remove this line: openapi-generator/bin/ensure-up-to-date Line 15 in 7dfd940
I prefer the build to be green over additional checks. |
@cbornet: Now that #233 is merged I wanted to update this PR. In order to do so you need to grant access:
When I try to push to your branch
You can pick the commit from my |
Shippable build is now OK. Thank you @cbornet. |
* master: Add 'unblu inc.' to company list (OpenAPITools#246) put company list in alphabetical order (OpenAPITools#244) [jaxrs-spec] generate spec file (yaml) correctly (OpenAPITools#243) [C++] Adjust the names (script, sample folder, generator) to lang option (OpenAPITools#220) Add GMO Pepabo to company list (OpenAPITools#242) [Spring] Add apiFirst option (OpenAPITools#184) [cli] Write to stdout/stderr, allow redirection (OpenAPITools#207) [JAVA][Client] New object instead of null for empty POST request (OpenAPITools#98) Make yaml serialization deterministic (OpenAPITools#233) Add syntax highlighting to migration guide (OpenAPITools#237) Fix shippable badge (OpenAPITools#232) update company list (OpenAPITools#227) Fix OpenAPITools#210: [Ada] Update the code generator for required and optional parameters (OpenAPITools#211) Delete unused methods in DefaultCodegen (OpenAPITools#209) add note about maven plugins (OpenAPITools#216) add raiffeisen to company list (OpenAPITools#223) add a remark about homebrew installatio (OpenAPITools#217)
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
.Description of the PR
This PR:
apiFirst
option that will not generate the API but will configure the openapi-generator-maven-plugin for API-first developpement instead.apiFirst
orreactive
is set (as Springfox doesn't support webflux yet)