-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few issues with the C generator (part 4) #20289
Conversation
With this change, the bodyParameters array can also be binary, so pass its length around instead of relying on strlen().
So the checks are passing, but I still think something is off because
while the other two samples are being built as plain C:
I don't know why this is happening. It does get fixed if I delete the whole sample folder and generate it again, for some reason. |
@eafer in the description, can you please list out (point form) what issues are fixed by this PR? |
@wing328 I just added the list of changes to the description. Let me know if you need anything else. |
Looks good 👍 |
I just deleted all the C samples and generated them from scratch. I don't understand enough to tell why the result is different, but it looks better now. |
I guess that wasn't the right thing to do... |
We can improve the CI/tests with another PR instead. |
Great, thanks! |
Four more patches from the original pull request at #14379. I reordered the patches this time because the last remaining two are somewhat harder to explain.
@wing328 @ityuhui @zhemant @michelealbano
I ran
generate-samples.sh
as usual, but I see something off with the results forpetstore/c/
. Not all of the cmake files are getting updated. I retried multiple times but I can't tell what I'm doing wrong.EDIT: This PR includes the following changes: