Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Handling null values for optional params while building the model json object #2301

Closed
wants to merge 2 commits into from

Conversation

Ramanth
Copy link
Contributor

@Ramanth Ramanth commented Mar 5, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Error when optional parameters are not given for the model object

When generating the json of a model using the toJSONString() we encounter an error when we dont pass the optional paramameters (which are of non-primitive type)

Below changes handles the listContainer type optional parameters by replacing them with "null". so that it will be ignored by the endpoint.

Please make necessary changes if required.
@wing328 , please look into and take required action.

Example to test:
please consider a model which is hanving an example as below

{
	"key1" : "value1",
	"key2" : [  {"k1" : "v1"},
                    {"k2" : "v2"} ],
	"key3" : {  "k3" : "v3",
                     "k4" : "v4"
         	      }
}

In the above example consider key2 as an optional parameter and of type listContainer (i.e, array).
Which is throwing an error when we dont provide the value for key2 while generating the model object.
Please review this changes and make required changes to handle such scenarios.

Thanks,
Ramanth.

when the optional params are not given by the user, the listContainer type params are being sent as empty [] which are being considered as empty values instead of null
@Ramanth Ramanth changed the title Handling null values for optional params while building the model json object [R] Handling null values for optional params while building the model json object Mar 5, 2019
{{/vars}}
)
outstring = gsub("[\r\n]| ", "", outstring)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this won't work if the data/value contains line breaks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328 you are right, i can remove this line considering what you mentioned. Thanks

@wing328
Copy link
Member

wing328 commented Mar 7, 2019

As discussed, instead of using sprintf, what about using string concatenation instead so that we can check for null before adding anything to the output?

@wing328
Copy link
Member

wing328 commented May 6, 2019

#2777 addresses this problem for Dart2. We should adopt a similar approach for R

@Ramanth
Copy link
Contributor Author

Ramanth commented Jun 4, 2019

raised a new PR with different approach.

@Ramanth Ramanth closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants