Enable async option for spring-cloud library #2670
Merged
+1,806
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zomzog
changed the title
|
Change the PR for comment on #2327 |
Zomzog
force-pushed
the
2327
branch
2 times, most recently
from
06176ad to
3bd42cd
Compare
cbornet
reviewed
Apr 30, 2019
| consumes = "application/json", | ||
| method = RequestMethod.POST) | ||
| default CompletableFuture<ResponseEntity<Void>> addPet(@ApiParam(value = "Pet object that needs to be added to the store" ,required=true ) @Valid @RequestBody Pet body) { | ||
| return CompletableFuture.completedFuture(new ResponseEntity<>(HttpStatus.NOT_IMPLEMENTED)); |
There was a problem hiding this comment.
Feign interfaces must not have default implementation so I don't think this works.
There was a problem hiding this comment.
You're right. I have redone the PR code for it.
Zomzog
force-pushed
the
2327
branch
2 times, most recently
from
1412408 to
2807494
Compare
|
@Zomzog when you've time, can you please resolve the merge conflicts? |
|
@wing328 Rebase done. |
|
@Zomzog can you please resolve the merge conflicts again? I'm sorry for the delay in reviewing your PR which results in merge conflicts. |
Zomzog
force-pushed
the
2327
branch
2 times, most recently
from
d3c981e to
98c8bd6
Compare
|
@wing328 merge conflicts resolved. |
|
@Zomzog thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Enable async option for spring-cloud library
Fix #2327
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03)