Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript Axios] fix Content-type not set properly #2695

Merged
merged 5 commits into from
Jul 30, 2019

Conversation

julaudo
Copy link
Contributor

@julaudo julaudo commented Apr 18, 2019

fixes #2694
[BUG][Typescript Axios] Content-type not set

@wing328
Copy link
Member

wing328 commented May 7, 2019

@julaudo thanks for the PR. For the allOf issue, do you have a spec to help reproduce the issue?

@julaudo
Copy link
Contributor Author

julaudo commented May 7, 2019

The allOf bug is another subject and should not be present is this pull request. To answer the question, the commit contains 2 specs to reproduce the bug (used by unit tests)

@macjohnny
Copy link
Member

cc @nicokoenig

@macjohnny macjohnny requested review from TiFu and jimschubert and removed request for TiFu June 25, 2019 11:16
@macjohnny
Copy link
Member

any update here?

@macjohnny
Copy link
Member

@julaudo can you please generate the samples?

@macjohnny macjohnny merged commit 6824bd8 into OpenAPITools:master Jul 30, 2019
@macjohnny macjohnny added this to the 4.1.0 milestone Jul 30, 2019
@wing328 wing328 changed the title #2694 [BUG][Typescript Axios] Content-type not set [BUG][Typescript Axios] fix Content-type not set properly Aug 9, 2019
@wing328 wing328 changed the title [BUG][Typescript Axios] fix Content-type not set properly [Typescript Axios] fix Content-type not set properly Aug 9, 2019
@wing328
Copy link
Member

wing328 commented Aug 10, 2019

@julaudo thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Typescript Axios] Content-type not set
3 participants