Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Inclusion of useragent, timeout and serialization #3084

Merged
merged 9 commits into from
Jun 25, 2019
Merged

[R] Inclusion of useragent, timeout and serialization #3084

merged 9 commits into from
Jun 25, 2019

Conversation

Ramanth
Copy link
Contributor

@Ramanth Ramanth commented Jun 4, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR has 3 changes

  1. Inclusion of user agent provided at the api client level in the http calls , which is missing previously.
  2. Adding of timeout parameter to the api client object, by which user can set timeout at apiclient level.
  3. Fixing the bug in serialization, when the post body is list of objects (array of json objects).

@wing328 Added few more enhancement.

@auto-labeler
Copy link

auto-labeler bot commented Jun 4, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@Ramanth Ramanth changed the title [R] feat(r): Inclusion of useragent timeout and serialization [R] feat(r): Inclusion of useragent, timeout and serialization Jun 4, 2019
@wing328
Copy link
Member

wing328 commented Jun 4, 2019

Looks like the sample (R petstore client) is not yet up-to-date: https://circleci.com/gh/OpenAPITools/openapi-generator/7033#tests/containers/2

@wing328 wing328 added this to the 4.0.2 milestone Jun 4, 2019
@wing328
Copy link
Member

wing328 commented Jun 4, 2019

Is the serialization fix in this PR the same as the one in "#3082" ?

If yes, I suggest we remove those changes in this PR so that it can be more easily merge into master.

@Ramanth
Copy link
Contributor Author

Ramanth commented Jun 4, 2019

@wing328 the serialization fix in this PR is different from the one i raised in the other PR. This should be able to merge independently.

@wing328
Copy link
Member

wing328 commented Jun 5, 2019

Please ping me via https://gitter.im (ID: wing328) or Google Hangout to have a quick chat on this when you've time.

bin/windows/r-petstore.bat Outdated Show resolved Hide resolved
@Ramanth
Copy link
Contributor Author

Ramanth commented Jun 10, 2019

@wing328 finished making the required changes. This PR should be ready to be merged. please take a look.

@wing328 wing328 modified the milestones: 4.0.2, 4.0.3 Jun 20, 2019
@wing328
Copy link
Member

wing328 commented Jun 24, 2019

@Ramanth thanks for the PR. When you've time, please resolve the merge conflicts so that we can review and merge the enhancement into master.

@wing328 wing328 merged commit f681764 into OpenAPITools:master Jun 25, 2019
@wing328 wing328 changed the title [R] feat(r): Inclusion of useragent, timeout and serialization [R] Inclusion of useragent, timeout and serialization Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants