-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] Inclusion of useragent, timeout and serialization #3084
[R] Inclusion of useragent, timeout and serialization #3084
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
modules/openapi-generator/src/main/resources/r/api_client.mustache
Outdated
Show resolved
Hide resolved
Looks like the sample (R petstore client) is not yet up-to-date: https://circleci.com/gh/OpenAPITools/openapi-generator/7033#tests/containers/2 |
Is the serialization fix in this PR the same as the one in "#3082" ? If yes, I suggest we remove those changes in this PR so that it can be more easily merge into master. |
@wing328 the serialization fix in this PR is different from the one i raised in the other PR. This should be able to merge independently. |
Please ping me via https://gitter.im (ID: wing328) or Google Hangout to have a quick chat on this when you've time. |
@wing328 finished making the required changes. This PR should be ready to be merged. please take a look. |
@Ramanth thanks for the PR. When you've time, please resolve the merge conflicts so that we can review and merge the enhancement into master. |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master
,4.1.x
,5.0.x
. Default:master
.Description of the PR
This PR has 3 changes
@wing328 Added few more enhancement.