Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][jesery2]: "InjectionManagerFactory not found" issue #3153

Merged

Conversation

saigiridhar21
Copy link
Contributor

@saigiridhar21 saigiridhar21 commented Jun 14, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

fixes:#3156

Jersey2 client is relying on jersey-client dependency of 2.27 version. After jersey-client 2.26 version, hk2 which is a hard dependency of jersey-client was removed. They created an SPI as a facade for the dependency injection provider, in the form of the InjectionManager and InjectionManagerFactory. So for Jersey to run, we need to have an implementation of the InjectionManagerFactory.
More details are available here(https://stackoverflow.com/a/51217530/3044493).

For supportJava6 option, we are using older version of jersey-client which has hk2 as hard dependency and so we need not add jersey-hk2 while generating library with that option.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

@auto-labeler
Copy link

auto-labeler bot commented Jun 14, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 4.0.3 milestone Jun 24, 2019
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit a038fcc into OpenAPITools:master Jun 24, 2019
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 24, 2019
* master:
  Ruby-client: Don't encode slashes if strict-spec false (OpenAPITools#3204)
  [openapi-yaml] Config option outputFile was ignored by the generator. (OpenAPITools#3199)
  Add missing javax dependencies for Java > 8 (OpenAPITools#3188)
  update kotlin samples
  Minor fix to presentation link
  Add Flow import to kotlin spring reactive (OpenAPITools#3107)
  Ktor Fix KtorExperimentalAPI import (OpenAPITools#3108)
  Add a link to the speaker deck at Kubernetes Contributor Summit (OpenAPITools#3205)
  [csharp] Adding http response details on api_docs and making example snippet compilable (OpenAPITools#3129)
  [java][jesery2]: "InjectionManagerFactory not found" issue (OpenAPITools#3153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Java]: "InjectionManagerFactory not found" issue for Jersey2
3 participants