Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added special handling for 'string' types with format 'uri' #3161

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

rainerh
Copy link
Contributor

@rainerh rainerh commented Jun 17, 2019

Added special handling for 'string' types with format 'uri':

  • implemented Kotlin
  • implemented Java

Fixes #3160

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

See #3160
Java/Kotlin generator changes for handling of string types with format uri.

@dr4ke616
@bbdouglas
@sreeshas
@jfiala
@lukoyanov
@cbornet
@jeff9finger
@jimschubert
@karismann
@Zomzog

Copy link
Contributor

@Zomzog Zomzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 3a1b29b into OpenAPITools:master Jun 28, 2019
@wing328
Copy link
Member

wing328 commented Jun 28, 2019

@rainerh thanks for the PR, which has been merged into master.

@Zomzog thanks for reviewing the change.

@wing328 wing328 added this to the 4.0.3 milestone Jun 28, 2019
@wing328 wing328 changed the title Added special handling for 'string' types with format 'uri' (OpenAPI… Added special handling for 'string' types with format 'uri' Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Java/Kotlin] type string with format as 'uri' does not compile
3 participants