[dart-jaguar] Adds option to customise the generated API client name

[josh-burton]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Derives the generated API class name from the pub name, rather than the generic JaguarApiGen name.

CC @ircecho @swipesight @jaumard

[wing328]

@athornz thanks for the PR. Quick question about the client name. Is that related to the pubName setting somehow?

        pubName
            Name in generated pubspec

If yes, shall we reuse pubName instead?

(disclosure: no expert in Dart)

[josh-burton]

It could make sense to reuse it, but the naming convention for dart packages is snake_case which is likely not what the user would want for the class name.

[wing328]

dart packages is snake_case which is likely not what the user would want for the class name.

We can use camelize, etc string utility function to convert pubName into proper format for {{clientName}} in the generator

[josh-burton]

Sure that seems like a good option 👍

[wing328]

The CircleCI error is not related to this PR.

Since it's a breaking change with fallback, I've retargeted this PR to 4.1.x branch.

[josh-burton]

Thanks!

[wing328]

@athornz have a nice weekend

[wing328]

@athornz thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553