[elm][haskell-servant] fix StringIndexOutOfBoundsException #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elewyth
changed the title
wing328
reviewed
Jul 3, 2019
modules/openapi-generator/src/test/java/org/openapitools/codegen/elm/ElmClientCodegenTest.java
Outdated
Show resolved
Hide resolved
wing328
reviewed
Jul 3, 2019
...nerator/src/test/java/org/openapitools/codegen/haskellservant/HaskellServantCodegenTest.java
Outdated
Show resolved
Hide resolved
Elewyth
force-pushed
the
fix_issue_3256
branch
2 times, most recently
from
a6979d6
to
e1aba26
Compare
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Fix #3256. Both the elm and haskell-servant generator had an issue handling root-operations (i.e.
/). This PR should introduce as little change as possible only handling this specific case, without affecting any other logic.