Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateTimeOffset nullable issue #3530

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

yilinjuang
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix DateTimeOffset part of issue #3528

@wing328
@mandrean
@jimschubert

Sorry, something went wrong.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me. Thanks for the PR.

@wing328 wing328 merged commit 93ddf6e into OpenAPITools:master Aug 1, 2019
@jimschubert
Copy link
Member

Thanks for the PR!

@yilinjuang yilinjuang deleted the fix-nullable-datetimeoffset branch August 2, 2019 06:14
@wing328
Copy link
Member

wing328 commented Aug 21, 2019

Upgrade Note

To make a property nullable in OpenAPI/Swagger spec 2.0, please use x-nullable: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants