[C#][client][csharp-netcore] Fix csharp netcore defaultheaders #3562
Conversation
mario-d-s
changed the title
mario-d-s
changed the title
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
| @@ -94,7 +94,7 @@ namespace {{packageName}}.Client | |||
| { | |||
| UserAgent = "{{#httpUserAgent}}{{.}}{{/httpUserAgent}}{{^httpUserAgent}}OpenAPI-Generator/{{packageVersion}}/csharp{{/httpUserAgent}}"; | |||
| BasePath = "{{{basePath}}}"; | |||
| DefaultHeader = new {{^net35}}Concurrent{{/net35}}Dictionary<string, string>(); | |||
| DefaultHeaders = new {{^net35}}Concurrent{{/net35}}Dictionary<string, string>(); | |||
There was a problem hiding this comment.
@mario-d-s I suggest we keep DefaultHeader as switching to DefaultHeaders will make this PR a breaking changes (without fallback), which means we will need to target this change to 5.0.x branch instead (scheduled to be released next year May)
There was a problem hiding this comment.
As a matter of fact I do keep the DefaultHeader around and loop it through the new DefaultHeaders (both get and set), but marked it as obsolete (see). I subsequently adjusted the rest of the files from using the obsolete property to the new one.
That is not to say I might not have missed a place where this is a breaking change, in that case please let me know but it should be safe AFAIK.
There was a problem hiding this comment.
Let's go with what you've and see if the community (users) spot anything we missed.
Oh thanks for spotting that! That's what you get when working from your day-job machine 😅. |
|
CircleCI failure has been fixed in the master. |
|
@mario-d-s thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553 |
* master: (122 commits) Fix #3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.@mandrean (2017/08), @jimschubert (2017/09)
Description of the PR
Fix #3561
Previously, the .NET Core SDK would not send configured default headers. This PR fixes this and also "fixes" the strange singular name of the property by marking it obsolete and redirecting to the new correctly-named plural form.
This second change is a separate commit and is less important so I'd drop it if need be.