Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated annotation in kotlin-spring #5090

Merged
merged 7 commits into from
Jan 29, 2020
Merged

Add deprecated annotation in kotlin-spring #5090

merged 7 commits into from
Jan 29, 2020

Conversation

yutaka0m
Copy link
Contributor

I want to embed @Deprecated annotation when deprecated: true in kotlin-spring

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu
@ackintosh

@ackintosh
Copy link
Contributor

Related issue: #3358

Copy link
Member

@jimschubert jimschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Small question about the empty message in the annotation.

Copy link
Contributor

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've left a small comment. Please have a look when you have time. 😃

@yutaka0m
Copy link
Contributor Author

@jimschubert @ackintosh Thanks for reviewing.

@wing328 wing328 merged commit 8214460 into OpenAPITools:master Jan 29, 2020
@wing328 wing328 added this to the 4.2.3 milestone Jan 29, 2020
@yutaka0m yutaka0m mentioned this pull request Jan 31, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants