Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[markdown] Show description when summary is missing #6159

Merged

Conversation

ybelenko
Copy link
Contributor

@ybelenko ybelenko commented May 4, 2020

Shows operation description when summary is missing.
Closes #6103

cc @jimschubert

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 added this to the 4.3.1 milestone May 5, 2020
@wing328 wing328 merged commit 90ff492 into OpenAPITools:master May 5, 2020
@wing328
Copy link
Member

wing328 commented May 7, 2020

@ybelenko thanks for the PR, which has been included in the v4.3.1 release: https://twitter.com/oas_generator/status/1258057660974329861

michaelpro1 pushed a commit to michaelpro1/openapi-generator that referenced this pull request May 7, 2020
jimschubert added a commit that referenced this pull request May 8, 2020
…-5.0

* origin/master: (78 commits)
  [powershell-experimental] : http signature authentication implementation (#6176)
  Add missing AnyType type mapping (#6196)
  remove pubspec.lock (#6208)
  Minor fixes post-release (#6204)
  [cpp][Qt5] Add the ability to pass QNetworkAccessManager as a parameter  (#6053)
  comment out dart2 test due to failure
  adds the missing typeMapping for AnyType (#6199)
  [Rust Server] Support boolean headers, and fix panic handling headers (#6056)
  update samples
  update 5.0.0 release date
  update readme with new release
  Prepare 4.3.1 release (#6187)
  Fix #6157: Updated native template to fix null async return (#6168)
  Show description when summary is missing (#6159)
  Make the array items optional (#6132)
  [aspnetcore] test petstore samples in drone.io (#6148)
  fix bearer auth in c# netcore async call (#6136)
  skip web.config for aspnetcore 3.x (#6147)
  Adds memoization and deserialization through 2 or more discriminators (#6124)
  Implement Asp.Net Core 3.0/3.1 generator (#6009) (#6025)
  ...
@ybelenko ybelenko deleted the 6103_markdown_descriptions_missing branch May 9, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][MARKDOWN] Method descriptions are missing from README.md
2 participants