Update to reset httpRepsonse.Body

[nmische]

… such that is available to client consumers via the returned httpResponse variable.

@antihax @grokify @kemokemo @bkabrda

Addresses #4799

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[nmische]

@antihax @grokify @kemokemo @bkabrda: Thoughts on this enhancement?

Also, I'm not sure what the problem is with the circleci build, so any help there would be appreciated.

[wing328]

@nmische I've fixed the CI failure by updating the samples.

I wonder if you can review #7041 as well since that PR seems to address similar issues.

[nmische]

@wing328: Thank you for the help with the CircleCI build!

I see a few challenges with #7041. First it doesn't really address the issue this PR seeks to address, which is that the returned response.Body can't be used to read the raw API response with the currently generated client. In #7041 this still appears to be an issue, while this PR re-sets the response.Body such that it can be re-read to access the raw response. (This can be very useful when debugging scenarios where the upstream API has returned malformed JSON.)

Second, #7041 changes the generated client's API in that it requires the caller to ensure they close the request body. With the currently generated client, and the update proposed in this PR, closing the request body is done by the generated client code. Thus users could update to the client generated by the templates in this PR and not have to change any of their existing code.

[gmtstephane]

I agree, this PR is more appropriate than my own #7041

[wing328]

@gmtstephane thanks for the review

@nmische thanks for the PR, which has been merged into master.

When you've time, I wonder if you can make the same enhancement to the go-experimental client generator:

openapi-generator/modules/openapi-generator/src/main/resources/go-experimental/api.mustache

Line 285 in a7ccc4a

localVarHTTPResponse.Body.Close()

[nmische]

@wing328: I'm happy to update the go-experimental client generator as well. I should be able to get to that later this week or early next.