Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go-server parse bool in query parameter #7724

Closed
wants to merge 3 commits into from
Closed

Go-server parse bool in query parameter #7724

wants to merge 3 commits into from

Conversation

gmtstephane
Copy link
Contributor

Hi, this PR allow support to boolean values in query parameters.
I change the petstore api example to generate a test case

The commits are pretty self explainatory, i added a function alongside parseInt32Parameter, and update the template in case of boolean value.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

schema:
type: boolean
default: true
example: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328
Copy link
Member

wing328 commented Oct 22, 2020

Please resolve the merge conflicts and undo the changes to petstore.yaml when you've time.

@wing328 wing328 added this to the 5.0.0 milestone Oct 22, 2020
@wing328 wing328 modified the milestones: 5.0.0, 5.0.1 Dec 21, 2020
@wing328 wing328 modified the milestones: 5.0.1, 5.1.0 Feb 8, 2021
@wing328 wing328 removed this from the 5.1.0 milestone Mar 19, 2021
@wing328
Copy link
Member

wing328 commented Apr 5, 2021

I've cherry-pick your commits, resolved the merged conflicts and filed #9171 instead.

@wing328 wing328 closed this Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants