Skip to content

[dart] Split mustache file by serialization #8958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

agilob
Copy link
Contributor

@agilob agilob commented Mar 12, 2021

No functional changes only code cleanup in mustache files so each serialization has own files, removes conditions from .mustache for readability.

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@kuhnroyal

@auto-labeler
Copy link

auto-labeler bot commented Mar 12, 2021

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@agilob
Copy link
Contributor Author

agilob commented Mar 12, 2021

The whitespace change (removal before fromJson()) is only in json_serializable code which hasnt been released yet.

@kuhnroyal
Copy link
Contributor

I started working on a new dio generator that would also support multiple serialization libraries here: #8869
We should use the same file structure for the partials, I have a separat sub folder serialization/built_value with the specific mustache files.

@agilob
Copy link
Contributor Author

agilob commented Mar 12, 2021

ok, will change it later today

@kuhnroyal
Copy link
Contributor

Looks good, probably don't need the native/json_serializable prefix anymore for the partials.

@agilob
Copy link
Contributor Author

agilob commented Mar 12, 2021

i thought so too, but it failed to find inlined enums without it

@agilob
Copy link
Contributor Author

agilob commented Mar 15, 2021

@wing328 can we get this in pls?

@kuhnroyal
Copy link
Contributor

Asked in Slack for a merge

@wing328 wing328 added this to the 5.1.0 milestone Mar 17, 2021
@wing328 wing328 merged commit 8a11a1a into OpenAPITools:master Mar 17, 2021
@agilob agilob deleted the dart-split-serialization-to-own-files branch September 25, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants