Skip to content

[dart] Ensure tests compile with Dart 2.12+ #8984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

kuhnroyal
Copy link
Contributor

@kuhnroyal kuhnroyal commented Mar 16, 2021

Tests were missing the header partial.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @agilob

Sorry, something went wrong.

@auto-labeler
Copy link

auto-labeler bot commented Mar 16, 2021

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@agilob
Copy link
Contributor

agilob commented Mar 17, 2021

How come tests arent failing on circle ci when it uses 2.12 for testing dart maven modules?

@kuhnroyal
Copy link
Contributor Author

Not sure tbh. But his happend locally.

@wing328 wing328 added this to the 5.1.0 milestone Mar 17, 2021
@wing328 wing328 merged commit d29d898 into OpenAPITools:master Mar 17, 2021
@kuhnroyal kuhnroyal deleted the dart/tests-2.12 branch March 17, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants