refactor: adjust some cache generation and usage behaviors #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kamiyadm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kamiyadm
force-pushed
the
fix-20241122-1
branch
6 times, most recently
from
49c0a4e to
421dda3
Compare
kamiyadm
force-pushed
the
fix-20241122-1
branch
2 times, most recently
from
4127698 to
bb66b31
Compare
The caches that have been processed are ld.so.cache and font cache. Code: * Add a new member ContainerBuilder to PackageManager. (package_manager) * Add a new scripts to gererate cache in container. (ld-cache-generator/font-cache-generator) * Add new func generateCache() to execute app-cache-generator. (pacakge_manager) * Add new func removeCache() to remove cache. (package_manager) * Mount the cache during running application. (cli) Mount:(host->container) * Remove /var/cache/fontconfig -> /var/cache/fontconfig * Add /usr/local/share/fonts -> /usr/local/share/fonts * Add /var/lib/linglong/cache/[hash] -> /run/linglong/cache * Add /var/lib/linglong/cache/[hash]/fontconfig -> /var/cache/fontconfig Config: (config.json) * Remove the hooks part. * Change env LINGLONG_LD_SO_CACHE to /run/linglong/cache/ld.so.cache. Log:
* In the build stage, create the cache directory in workdir and mount it to /run/linglong/cache. Then generate ld.so.cache in the hook. * In the run stage, mount the cache dirctory and generate both the ld.so.cache and font cache. Log:
kamiyadm
force-pushed
the
fix-20241122-1
branch
2 times, most recently
from
61024e9 to
7a872f0
Compare
ComixHe
requested changes
Dec 12, 2024
* Add dbus method GenerateCache, signal GenerateCacheFinished. (PM) * Add an exclusive write lock to the application cache in ensureCache to ensure that the container runs after the cache is generated. (cli) Log:
If LINGLONG_SKIP_HOME_GENERATE is set, don't mount the home dir of host. Log:
* If the XDG_DATA_DIRS is not set, the dir that used for storage container state will fallback to /run/ll-box. deepin-linglong has no permission to create dir in /run, so we should specific a writable path to ll-box. * Change Container::run(Process) to Container::run(Process, RunOption), we need to support specific run option. Log:
Signed-off-by: ComixHe <heyuming@deepin.org>
kamiyadm
force-pushed
the
fix-20241122-1
branch
from
7a872f0 to
f375a7b
Compare
ComixHe
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caches that have been processed are ld.so.cache and font cache.
Code:
Mount:(host->container)
Config:
Log: