Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some errors #890

Merged
merged 3 commits into from
Nov 27, 2024
Merged

fix some errors #890

merged 3 commits into from
Nov 27, 2024

Conversation

ComixHe
Copy link
Collaborator

@ComixHe ComixHe commented Nov 27, 2024

  • fix: ignore version while creating PackageTask
  • fix: access value to unexpected
  • fix: remove symlink or empty directory before checkout

After we removed support of multi-verison app, PackageTask must
ignore version to avoid installing multi-verison at the same time

Signed-off-by: ComixHe <heyuming@deepin.org>
Signed-off-by: ComixHe <heyuming@deepin.org>
@ComixHe ComixHe requested a review from kamiyadm November 27, 2024 06:50
kamiyadm
kamiyadm previously approved these changes Nov 27, 2024
Signed-off-by: ComixHe <heyuming@deepin.org>
@deepin-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComixHe, kamiyadm
Once this PR has been reviewed and has the lgtm label, please assign black-desk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ComixHe ComixHe merged commit c56da37 into OpenAtom-Linyaps:master Nov 27, 2024
5 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants