[HUST-CSE]Add null pointer check in OSA_TaskSetPriority #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.这个PR修复的是什么问题?
源码 :
if (ptaskStruct->priority > tcb->priority)
这段代码在while循环未进入时,tcb易产生空指针问题
此处给出文件路径:
platform/vendor_bsp/nxp/MIMXRT1052/components/osa/fsl_os_abstraction_bm.c
2.这个PR不修复具体会带来什么后果?
tcb->priority无效,并会导致指针错误、程序崩溃
3.PR修复方案的依据是什么?
在原判断条件的基础上,添加对于空指针的检验,保证了代码的安全性:
if ((NULL == tcb) || (ptaskStruct->priority > tcb->priority))
4. 在什么环境下测试或者验证过?
all