[HUST CSE]Modify the null pointer fifo to access first and then judge #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.为什么提交这份PR (why to submit this PR)
在/components/connectivity/mqttclient/common/log/fifo.c这个文件中,第101行
这处代码首先进行salof_sem_pend(fifo->sem, timeout)再进行判断fifo是否为空有问题,如果fifo为空,则访问其成员变量会导致未定义的行为。
2.你的解决方案是什么 (what is your solution)
应该先检查传入的salof_fifo_t类型的参数fifo是否为空(即是否为NULL),然后才能使用它的成员变量。因此,应该将if((!fifo) || (!buff) || (!len))这个语句的判断移到salof_sem_pend(fifo->sem, timeout)之前。
3.在什么测试环境下测试通过 (what is the test environment)
all