Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

全量同步RsyncReader在读写数据异常时，缺少记录错误码和日志 #2287

Closed
chengyu-l opened this issue Jan 10, 2024 · 0 comments
Closed

全量同步RsyncReader在读写数据异常时，缺少记录错误码和日志 #2287

chengyu-l opened this issue Jan 10, 2024 · 0 comments
Labels
☢️ Bug Something isn't working

Comments

@chengyu-l
Copy link
Contributor

Is this a regression?

Yes

Description

（1）open 文件失败时，没有记录日志，在外部调用处也没有记录日志，不利于发现问题和问题定位。并且在返回的错误信息中没有包含错误码，不知道为什么会open失败。
image

image

（2）pread 如果读取数据异常，没有在日志和返回的错误信息中包含错误码（errno），不利于问题定位。
image

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

No response

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response
@chengyu-l chengyu-l added the ☢️ Bug Something isn't working label Jan 10, 2024
chengyu-l pushed a commit to chengyu-l/pika that referenced this issue Jan 12, 2024
fix: without errno in log or status when open and read file failed(Op…
b862e26 
…enAtomFoundation#2287)
@chengyu-l chengyu-l mentioned this issue Jan 12, 2024
Closed
chengyu-l pushed a commit to chengyu-l/pika that referenced this issue Jan 12, 2024
fix: without errno in log or status when open and read file failed(Op…
ce2c615 
…enAtomFoundation#2287, OpenAtomFoundation#2292)
@chengyu-l chengyu-l mentioned this issue Jan 12, 2024
Merged
chengyu-l pushed a commit to chengyu-l/pika that referenced this issue Jan 12, 2024
fix: without errno in log or status when open and read file failed(Op…
4d9d9ac 
…enAtomFoundation#2287, OpenAtomFoundation#2292)
AlexStocks pushed a commit that referenced this issue Jan 12, 2024
@chengyu-l
fix: without errno in log or status when open and read file failed(#2287
79b5fba 
, #2292) (#2307)

Co-authored-by: liuchengyu <liuchengyu@360.cn>
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this issue Jun 8, 2024
@chengyu-l
fix: without errno in log or status when open and read file failed(Op…
f22d103 
…enAtomFoundation#2287, OpenAtomFoundation#2292) (OpenAtomFoundation#2307)

Co-authored-by: liuchengyu <liuchengyu@360.cn>
cheniujh pushed a commit to cheniujh/pika that referenced this issue Sep 24, 2024
@chengyu-l
fix: without errno in log or status when open and read file failed(Op…
2f6fc03 
…enAtomFoundation#2287, OpenAtomFoundation#2292) (OpenAtomFoundation#2307)

Co-authored-by: liuchengyu <liuchengyu@360.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chengyu-l