fix:fix Zpopmaxbugs return value not same as redis #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
☢️ Bug
|
great work. please add ut in Go too. thx. |
|
需要补充 go 语言单测 |
Mixficsol
reviewed
Dec 14, 2023
Mixficsol
approved these changes
Dec 21, 2023
Mixficsol
merged commit 9e26988
into
OpenAtomFoundation:unstable
12 of 13 checks passed
chejinge
changed the title
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* feat:unstable branch * feat:handle merge * feat:add lastsave cmd * feat:update lastsave cmd * feat:update lastsave cmd * feat:fixed lastsave cmd * feat:fixed server_test.go * feat:fixed server_test.go * feat:fixed server_test.go * feat:fixed server_test.go * feat:update modifies * feat:fixed zpopmax etc. bug * feat:add zpopmax ut * feat:fixed ut bugs * feat:fixed ut * feat:update code * feat:update ut
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* feat:unstable branch * feat:handle merge * feat:add lastsave cmd * feat:update lastsave cmd * feat:update lastsave cmd * feat:fixed lastsave cmd * feat:fixed server_test.go * feat:fixed server_test.go * feat:fixed server_test.go * feat:fixed server_test.go * feat:update modifies * feat:fixed zpopmax etc. bug * feat:add zpopmax ut * feat:fixed ut bugs * feat:fixed ut * feat:update code * feat:update ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue bug: the return value of Pika ZPOPMAX is not the same as Redis
修复参数个数超过了，缺少了一些判断逻辑导致和Redis那边的返回值不一致问题：
排查问题命令有：