fix: command CONFIG SET * reply array length error(#2320)
#2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
578223592
changed the title
CONFIG SET * reply array length error(#2320)
|
当我运行 |
|
文件冲突太多，建议重新提交 pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2320
1.修复结果：
2.统一了该命令的回复方式，统一使用成员变量
res_回复，由于不需要返回值对应修改了ConfigSet方法的签名3.修复了
AppendStringVector的回复值4.疑问：https://github.com/OpenAtomFoundation/pika/blob/77e87bb725724039e5d8cbdac29addcee2620774/src/pika_admin.cc#L2064
中表示要与
rewrite同步，但是检查后发现configset和configrewrite方法并没有完全同步，这正常吗？5.疑问：延续2，是否要继续修改ConfigCmd::Do方法中用到的其他方法的签名，统一成
ConfigSet的返回形式(用res_成员变量返回)？