fix: add rename go test #2468
Merged
fix: add rename go test #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
☢️ Bug
Mixficsol
added
test
3.5.3
and removed
☢️ Bug
github-actions
bot
added
☢️ Bug
Mixficsol
removed
✏️ Feature
luky116
reviewed
Mar 7, 2024
| n, err := client.Exists(ctx, "key").Result() | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(n).To(Equal(int64(0))) | ||
| r = client.Do(ctx, "flushdb") |
There was a problem hiding this comment.
如果执行 flushdb，那应该返回错误，因为你把 flushdb 命令重命名了？
There was a problem hiding this comment.
返回错误和结果不是OK是不是逻辑一样，NotTo(Equal("OK"))
luky116
approved these changes
Mar 11, 2024
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
add rename-command go test
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
add rename-command go test
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
add rename-command go test
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
add rename-command go test
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
add rename-command go test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2046