Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] Improv performance on atomic testing pagination list #1084

Merged
merged 3 commits into from
Jun 26, 2024
Merged

[backend] Improv performance on atomic testing pagination list #1084

merged 3 commits into from
Jun 26, 2024

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois force-pushed the improvment/atomic-testing branch from c3f721c to e7de8d6 Compare June 14, 2024 20:55
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.42017% with 237 lines in your changes missing coverage. Please review.

Project coverage is 26.18%. Comparing base (9def8d5) to head (72f01ab).
Report is 1 commits behind head on master.

Files Patch % Lines
.../java/io/openbas/service/AtomicTestingService.java 0.59% 168 Missing ⚠️
...penbas/rest/inject/output/AtomicTestingOutput.java 0.00% 28 Missing ⚠️
...main/java/io/openbas/utils/AtomicTestingUtils.java 0.00% 17 Missing ⚠️
...rc/main/java/io/openbas/service/InjectService.java 0.00% 16 Missing ⚠️
...va/io/openbas/rest/inject/output/InjectOutput.java 0.00% 7 Missing ⚠️
.../openbas/rest/atomic_testing/AtomicTestingApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1084      +/-   ##
============================================
- Coverage     26.32%   26.18%   -0.15%     
- Complexity     1059     1062       +3     
============================================
  Files           474      475       +1     
  Lines         11327    11530     +203     
  Branches        579      599      +20     
============================================
+ Hits           2982     3019      +37     
- Misses         8261     8426     +165     
- Partials         84       85       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois force-pushed the improvment/atomic-testing branch from e7de8d6 to 1456b3c Compare June 17, 2024 13:55
@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Jun 18, 2024
@RomuDeuxfois RomuDeuxfois force-pushed the improvment/atomic-testing branch from 1456b3c to 6cd2f88 Compare June 24, 2024 07:36
@Dimfacion
Copy link
Member

image
It looks like there is an issue here

@RomuDeuxfois RomuDeuxfois force-pushed the improvment/atomic-testing branch from e5fd6c0 to e5ca214 Compare June 24, 2024 14:58
@RomuDeuxfois
Copy link
Member Author

image It looks like there is an issue here

Fix

@Dimfacion Dimfacion force-pushed the improvment/atomic-testing branch from e5ca214 to 72f01ab Compare June 26, 2024 13:58
@Dimfacion Dimfacion merged commit 7682415 into master Jun 26, 2024
6 checks passed
@SamuelHassine SamuelHassine deleted the improvment/atomic-testing branch June 30, 2024 20:32
johanah29 pushed a commit that referenced this pull request Jul 16, 2024
@RomuDeuxfois @Dimfacion @johanah29
[backend] Improv performance on atomic testing pagination list (#1084)
52cbe2b 
* [backend] Improv performance on atomic testing pagination list

* [backend] Add contract to AtomicTestingOutput

* [backend] Rebase

---------

Co-authored-by: Gael Leblan <gael.leblan@filigran.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dimfacion Dimfacion Dimfacion approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomuDeuxfois @Dimfacion