Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Add validation mode to manual expectations #1245

Merged
merged 47 commits into from
Aug 11, 2024
Merged

[frontend] Add validation mode to manual expectations #1245

merged 47 commits into from
Aug 11, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Jul 24, 2024

Proposed changes

  • Add option all target/ at least player for manual expe
  • Create expectation for players
  • Refact validation view
  • Refact atomic overview to show manual exp by player
  • Re adjust position of icons of expectation results

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 linked an issue Jul 24, 2024 that may be closed by this pull request
@savacano28 savacano28 self-assigned this Jul 24, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Jul 24, 2024
@savacano28 savacano28 modified the milestone: Release 1.4.0 Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 7.96915% with 358 lines in your changes missing coverage. Please review.

Project coverage is 28.26%. Comparing base (bd8bf3f) to head (bab06ef).

Files Patch % Lines
...main/java/io/openbas/service/ChallengeService.java 1.19% 83 Missing ⚠️
...io/openbas/service/ExerciseExpectationService.java 7.79% 66 Missing and 5 partials ⚠️
...c/main/java/io/openbas/service/ChannelService.java 1.53% 64 Missing ⚠️
...main/java/io/openbas/utils/AtomicTestingUtils.java 0.00% 53 Missing ⚠️
...c/main/java/io/openbas/utils/ExpectationUtils.java 0.00% 40 Missing ⚠️
...c/main/java/io/openbas/rest/helper/TeamHelper.java 0.00% 13 Missing ⚠️
...openbas/injectors/challenge/ChallengeExecutor.java 0.00% 11 Missing ⚠️
.../src/main/java/io/openbas/helper/InjectHelper.java 0.00% 5 Missing ⚠️
...as/migration/V2_63__InjectExpectation_upgrade.java 0.00% 3 Missing ⚠️
...n/java/io/openbas/rest/challenge/ChallengeApi.java 25.00% 3 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1245      +/-   ##
============================================
- Coverage     28.73%   28.26%   -0.47%     
+ Complexity     1290     1277      -13     
============================================
  Files           510      513       +3     
  Lines         13108    13269     +161     
  Branches        748      779      +31     
============================================
- Hits           3766     3751      -15     
- Misses         9182     9355     +173     
- Partials        160      163       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 changed the title [frontend] add validtion mode to manual expectations [frontend] Add validation mode to manual expectations Jul 24, 2024
@savacano28 savacano28 force-pushed the issue/184 branch 3 times, most recently from dd5c243 to 313c11b Compare August 5, 2024 08:36
@savacano28 savacano28 marked this pull request as ready for review August 5, 2024 08:51
@savacano28 savacano28 marked this pull request as draft August 6, 2024 08:42
@savacano28 savacano28 marked this pull request as ready for review August 6, 2024 11:11

@Service
@AllArgsConstructor
public class ChannelService {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kedae Kedae merged commit b597647 into master Aug 11, 2024
6 checks passed
@savacano28 savacano28 deleted the issue/184 branch August 29, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to choose if expectation must be individually validated
3 participants