Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix param to retrieve asset groups from a raw map #1710

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

savacano28
Copy link
Contributor

Proposed changes

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Oct 21, 2024
@savacano28 savacano28 self-assigned this Oct 21, 2024
@savacano28 savacano28 marked this pull request as ready for review October 21, 2024 13:46
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.53%. Comparing base (566e6c8) to head (9d32dd4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...main/java/io/openbas/utils/AtomicTestingUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1710   +/-   ##
=========================================
  Coverage     33.53%   33.53%           
  Complexity     1608     1608           
=========================================
  Files           557      557           
  Lines         14476    14476           
  Branches        871      871           
=========================================
  Hits           4854     4854           
  Misses         9397     9397           
  Partials        225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 merged commit 55d481f into master Oct 21, 2024
7 checks passed
@savacano28 savacano28 deleted the bugfix/Fix-param-to-map branch October 23, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants