Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] use client time for last ping date in sse client (#2126) #2187

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

guillaumejparis
Copy link
Member

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.64%. Comparing base (b635306) to head (2fad952).
Report is 11 commits behind head on release/1.11.0.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.11.0    #2187      +/-   ##
====================================================
+ Coverage             32.51%   32.64%   +0.12%     
- Complexity             1511     1514       +3     
====================================================
  Files                   581      581              
  Lines                 18063    18063              
  Branches               1158     1158              
====================================================
+ Hits                   5874     5896      +22     
+ Misses                11925    11903      -22     
  Partials                264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillaumejparis guillaumejparis merged commit 3c6f7c9 into release/1.11.0 Jan 13, 2025
6 checks passed
@guillaumejparis guillaumejparis deleted the issue/2126 branch January 13, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants