Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The loaded ticker drops off when you enter the stocks/sia menu #1814

Closed
JerBouma opened this issue May 13, 2022 · 5 comments · Fixed by #1853
Closed

[Bug] The loaded ticker drops off when you enter the stocks/sia menu #1814

JerBouma opened this issue May 13, 2022 · 5 comments · Fixed by #1853
Assignees
Labels
bug Fix bug

Comments

@JerBouma
Copy link
Contributor

Describe the bug
The loaded ticker drops off when you enter the stocks/sia menu. Also note the terrible x-axis for the metric plot.

To Reproduce

2022 May 13, 09:25 (🦋) /stocks/ $ load AMZN

Loading Daily AMZN stock with starting period 2019-05-08 for analysis.

Datetime: 2022 May 13 09:25
Timezone: America/New_York
Currency: USD
Market:   OPEN
Company:  Amazon.com, Inc.

                                            AMZN Performance                                            
┏━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ 1 Day   ┃ 1 Week  ┃ 1 Month  ┃ 1 Year   ┃ YTD      ┃ Volatility (1Y) ┃ Volume (10D avg) ┃ Last Price ┃
┡━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ -1.77 % │ -8.14 % │ -29.09 % │ -32.35 % │ -37.25 % │ 31.43 %         │ 6.51 M           │ 2138.61    │
└─────────┴─────────┴──────────┴──────────┴──────────┴─────────────────┴──────────────────┴────────────┘

2022 May 13, 09:25 (🦋) /stocks/ $ sia
╭────────────────────────────────────────────────────────────────────────────────────────────────── Stocks - Sector and Industry Analysis ──────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                                                                                                                                           │
│     load          load a specific ticker and all it's corresponding parameters                                                                                                                                                            │
│                                                                                                                                                                                                                                           │
│     clear         clear all or one of industry, sector, country and market cap parameters                                                                                                                                                 │
│     industry      see existing industries, or set industry if arg specified                                                                                                                                                               │
│     sector        see existing sectors, or set sector if arg specified                                                                                                                                                                    │
│     country       see existing countries, or set country if arg specified                                                                                                                                                                 │
│     mktcap        set mktcap between nano, micro, small, mid, large or mega                                                                                                                                                               │
│     exchange      revert exclude international exchanges flag                                                                                                                                                                             │
│     period        set period between annual, quarterly or trailing [StockAnalysis]                                                                                                                                                        │
│                                                                                                                                                                                                                                           │
│ Industry          : Internet Retail                                                                                                                                                                                                       │
│ Sector            : Consumer Cyclical                                                                                                                                                                                                     │
│ Country           : United States                                                                                                                                                                                                         │
│ Market Cap        : Large                                                                                                                                                                                                                 │
│ Exclude Exchanges : True                                                                                                                                                                                                                  │
│ Period            : Annual                                                                                                                                                                                                                │
│                                                                                                                                                                                                                                           │
│ Statistics                                                                                                                                                                                                                                │
│     cps           companies per Sector based on Country and Market Cap                                                                                                                                                                    │
│     cpic          companies per Industry based on Country and Market Cap                                                                                                                                                                  │
│     cpis          companies per Industry based on Sector and Market Cap                                                                                                                                                                   │
│     cpcs          companies per Country based on Sector and Market Cap                                                                                                                                                                    │
│     cpci          companies per Country based on Industry and Market Cap                                                                                                                                                                  │
│                                                                                                                                                                                                                                           │
│ Financials  [Yahoo Finance]                                                                                                                                                                                                               │
│     sama          see all metrics available                                                                                                                                                                                               │
│     metric        visualize financial metric across filters selected                                                                                                                                                                      │
│ Financials  [StockAnalysis]                                                                                                                                                                                                               │
│     satma         see all metrics available over time                                                                                                                                                                                     │
│     vis           visualize financial metric across filters selected                                                                                                                                                                      │
│                                                                                                                                                                                                                                           │
│ Returned tickers:                                                                                                                                                                                                                         │
│ >   ca            take these to comparison analysis menu                                                                                                                                                                                  │
│                                                                                                                                                                                                                                           │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── OpenBB Terminal v1.0 (https://openbb.co) ─╯
2022 May 13, 09:25 (🦋) /stocks/sia/ $ metric roa
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 5/5 [00:05<00:00,  1.09s/it]

2022 May 13, 09:25 (🦋) /stocks/sia/ $ vis re
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 5/5 [00:04<00:00,  1.15it/s]

Screenshots
metric roa
Figure_13

vis re
Figure_14

@JerBouma JerBouma added the bug Fix bug label May 13, 2022
@DidierRLopes DidierRLopes self-assigned this May 21, 2022
@DidierRLopes
Copy link
Collaborator

Screenshot 2022-05-21 at 22 07 24

Will be fixed in #1853

@DidierRLopes
Copy link
Collaborator

I did not experience the loss of the ticker tho...

@JerBouma
Copy link
Contributor Author

That images still doesn't show Amazon right?

@DidierRLopes
Copy link
Collaborator

OHHH you mean within! I thought you meant upon leaving the terminal! Let me investigate this!

DidierRLopes added a commit that referenced this issue May 21, 2022
@DidierRLopes
Copy link
Collaborator

@JerBouma it is fixed now.

The sia menu only used 3 market caps, and in the meantime you added Large, Micro and Nano. So now all of those market cap tickers were being lost when we were selecting one of the other market caps.

It is fixed now

DidierRLopes added a commit that referenced this issue May 21, 2022
* fix #1850

* fix #1831

* add extra check to Reddit API keys

* ignore warning message to update praw api

* improve OpenBB links

* fix quick performance only on stocks class because I'm James bitch

* fix quick performance only on stocks class because I'm James bitch

* fix #1829

* fix #1821

* add messari to keys - fix #1819

* example of multiple oclumns to check on options/chains

* minor improvement in xlabel re. #1814

* remove repeated command

* fix #1698

* fix line too long

* fix #1814 fr now

* fix tests
piiq added a commit that referenced this issue Jun 6, 2022
* fix #1850

* fix #1831

* add extra check to Reddit API keys

* ignore warning message to update praw api

* improve OpenBB links

* fix quick performance only on stocks class because I'm James bitch

* fix quick performance only on stocks class because I'm James bitch

* fix #1829

* fix #1821

* add messari to keys - fix #1819

* example of multiple oclumns to check on options/chains

* minor improvement in xlabel re. #1814

* remove repeated command

* fix #1698

* fix line too long

* fix #1814 fr now

* fix tests

* Fix multiple bugs

* Disable false positive pylint in some crypto models

* Fix website not building because of expo command removed

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants