Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Error while setting binance API Key #2006

Closed
wandesky opened this issue Jun 28, 2022 · 2 comments
Closed

[Bug] Error while setting binance API Key #2006

wandesky opened this issue Jun 28, 2022 · 2 comments
Labels
bug Fix bug

Comments

@wandesky
Copy link

Describe the bug
A clear and concise description of what the bug is.
The application fails to add the Binance API key

To Reproduce

  • downloaded the latest (28th June 2022) copy of the Windows installer from openBB downloads page
  • Installed the application using default settings
  • access the keys page
  • try to set binance key by using command binance myprivateAPIkey

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Python version 3.9.6
    image

Additional context
Other API keys setup commands appear to be working other than Binance

Error Message(s)
str expected not nonetype openbb
the following args couldn't be interpreted
@wandesky
Copy link
Author

Running the command
binance -k myAPIkey -s myAPIsecret
appeared to successfully set the API key and secret. The challenge I'm facing now is that the key is not getting tested (defined, not tested). Not sure if there is a way I can trigger the test from the CLI.
image

@DidierRLopes DidierRLopes added the bug Fix bug label Jul 1, 2022
soggyomelette added a commit to soggyomelette/OpenBBTerminal that referenced this issue Jul 1, 2022
@soggyomelette
Adds a test for binance key as asked for in OpenBB-finance#2006
d7893c0
DidierRLopes added a commit that referenced this issue Jul 2, 2022
@soggyomelette @DidierRLopes
Adds a test for binance key as asked for in #2006 (#2026)
7849b56 
* Adds a test for binance key as asked for in #2006

* Update keys_controller.py

* Update keys_controller.py

* fixing linting

* fixing tests

* fixing linting

* fix tests

* fix linting

* fix linting

* fix linting

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
@DidierRLopes
Copy link
Collaborator

This has been fixed by @soggyomelette ! Closing issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fix bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wandesky @DidierRLopes