Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Sentiment Investor features are dead: Cannot read properties of undefined (reading 'map')" #2212

Closed
deeleeramone opened this issue Jul 30, 2022 · 3 comments · Fixed by #2284
Assignees
Labels
bug Fix bug

Comments

@deeleeramone
Copy link
Contributor

With the ticker loaded, GME, this is the output for both /stocks/ba/trend and /stocks/ba/history

Screen Shot 2022-07-30 at 12 13 10 PM

@github-actions github-actions bot added the bug Fix bug label Jul 30, 2022
@raviolispy
Copy link
Contributor

raviolispy commented Jul 31, 2022

I can't reproduce the trend error above running Python from WSL. The trend function returns a result for me but at first glance it appears to be exclusively cryptos:
image

I tried to see if anything equities are supported at all with the "All Supported Tickers" endpoint and unsurprisingly there are no supported equities right now, only cryptos which explains why the hist function doesn't work.

image

I tried bypassing the supported ticker check and querying anyway to see if it was a bug on their end and I get an unsupported error from the API:
image

Seems like a bug or "feature" on their end, perhaps they're moving away from supporting equities on the free tier and forgot to update their docs or something. It could also be something to do with querying outside of market hours but I've never used this function or API before so not sure what the expected behavior is.

I'm happy to clean this up to fail a bit more gracefully if needed - let me know how you guys want to handle it.

@DidierRLopes
Copy link
Collaborator

Sorry for the delay on the reply on our end.

Seems like they are moving to crypto only:
Screenshot 2022-08-08 at 00 11 34

Are you ok to remove those 2 commands from the stocks menu? Thanks! 🙏🏽

@raviolispy
Copy link
Contributor

Sure, I can remove the commands - will do sometime this week

jmaslek added a commit that referenced this issue Sep 17, 2022
* Removed hist and trend comamnds from /stocks/ba

* Removed trend and hist command from /stocks/ba help menu

* Fixed whitespace issue

* Fixed test_print_help for ba controller

* Fixed pylint issues

* fix test

Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com>
Co-authored-by: Ravioli Spy <raviolispy@users.noreply.github.com>
Co-authored-by: James Maslek <jmaslek11@gmail.com>
Co-authored-by: colin99d <colin99delahunty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants