Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Stocks/FA/income --plot: Error: could not convert string to float: 'USD' #4277

Closed
deeleeramone opened this issue Feb 18, 2023 · 1 comment · Fixed by #4142
Closed
Assignees
Labels

Comments

@deeleeramone
Copy link
Contributor

deeleeramone commented Feb 18, 2023

The same errors happens using balance and cash.

Recreate with:

/stocks/load AAPL/fa/income --plot revenue
2023 Feb 17, 22:21 (🦋) /stocks/fa/ $ income --plot revenue

Error: could not convert string to float: 'USD'

The help dialogue has conflicting statements for the --plot argument. Are we plotting a column, or a row? Not clear.

Screenshot 2023-02-17 at 7 25 02 PM

Presented choices are begging for the function to fail:

Screenshot 2023-02-17 at 7 28 45 PM

2023 Feb 17, 22:21 (🦋) /stocks/fa/ $ income --plot cik

Error: could not convert string to float: 'USD'


2023 Feb 17, 22:21 (🦋) /stocks/fa/ $ income --plot revenue

Error: could not convert string to float: 'USD'


2023 Feb 17, 22:22 (🦋) /stocks/fa/ $ income --plot link

Error: could not convert string to float: 'USD'


2023 Feb 17, 22:27 (🦋) /stocks/fa/ $ income --plot eps

Error: could not convert string to float: 'USD'

Unclear why only row[0] is of interest when the key value is changing. Certainly no need to plot the filing date against the Fiscal Year.

The docstrings "description" are strange. Why only AlphaVantage

@deeleeramone deeleeramone added the bug Fix bug label Feb 18, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Feb 18, 2023

#4142

@northern-64bit northern-64bit self-assigned this Feb 19, 2023
@northern-64bit northern-64bit linked a pull request Feb 19, 2023 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants