-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3873 and adds generic naming to financial statements #4142
Merged
jmaslek
merged 24 commits into
OpenBB-finance:develop
from
northern-64bit:hotfix/bug-#3873
Feb 20, 2023
Merged
Fixes #3873 and adds generic naming to financial statements #4142
jmaslek
merged 24 commits into
OpenBB-finance:develop
from
northern-64bit:hotfix/bug-#3873
Feb 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I choose to fix it by removing the denomination transform, since it doesn't affect the result (even when fixed).
I still get an error when I run the command reported in the issue:
|
Also the cash and balance commands from fmp:
Also from AV:
|
8 tasks
@jmaslek The errors have now been fixed. |
So there is still an issue if we pick an invalid column:
|
This has now been fixed. @jmaslek |
jmaslek
approved these changes
Feb 20, 2023
reviewpad
bot
added
feat XL
Extra Large feature
and removed
feat L
Large T-Shirt size Feature
labels
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3873
It also add generic naming to financial statements, except for the EODHD source
How has this been tested?
Running the command for different firms and sources
Checklist:
Others