Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3873 and adds generic naming to financial statements #4142

Merged
merged 24 commits into from
Feb 20, 2023

Conversation

northern-64bit
Copy link
Contributor

Description

Closes #3873

It also add generic naming to financial statements, except for the EODHD source

How has this been tested?

Running the command for different firms and sources

  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

I choose to fix it by removing the denomination transform, since it doesn't affect the result (even when fixed).
@northern-64bit northern-64bit added bug Fix bug enhancement Enhancement labels Feb 6, 2023
@reviewpad reviewpad bot added the feat L Large T-Shirt size Feature label Feb 6, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Feb 8, 2023

I still get an error when I run the command reported in the issue:

2023 Feb 07, 19:28 (🦋) /stocks/fa/ $ cash --source FinancialModelingPrep --plot net_income

Error: 'reportedcurrency'

@jmaslek
Copy link
Collaborator

jmaslek commented Feb 8, 2023

Also the cash and balance commands from fmp:

2023 Feb 07, 19:29 (🦋) /stocks/fa/ $ cash

Error: "['Final link'] not found in axis"
2023 Feb 07, 19:30 (🦋) /stocks/fa/ $ balance

Error: 'othertotal_stockholders_equity'

Also from AV:

2023 Feb 07, 19:33 (🦋) /stocks/fa/ $ balance --source AlphaVantage

Error: 'othernoncurrentassets'

@northern-64bit
Copy link
Contributor Author

I still get an error when I run the command reported in the issue:

2023 Feb 07, 19:28 (🦋) /stocks/fa/ $ cash --source FinancialModelingPrep --plot net_income

Error: 'reportedcurrency'

@jmaslek The errors have now been fixed.

@jmaslek
Copy link
Collaborator

jmaslek commented Feb 16, 2023

So there is still an issue if we pick an invalid column:

2023 Feb 16, 10:08 (🦋) /stocks/fa/ $ balance --plot fixed_assets

Error: 'fixed_assets'

@jmaslek
Copy link
Collaborator

jmaslek commented Feb 16, 2023

Also slightly out of scope, but the labeling on the axis are in scientific notation:

Screenshot 2023-02-16 at 10 10 47 AM

@northern-64bit
Copy link
Contributor Author

So there is still an issue if we pick an invalid column:

2023 Feb 16, 10:08 (🦋) /stocks/fa/ $ balance --plot fixed_assets

Error: 'fixed_assets'

This has now been fixed. @jmaslek

@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat L Large T-Shirt size Feature labels Feb 20, 2023
@jmaslek jmaslek merged commit 33e79a2 into OpenBB-finance:develop Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug enhancement Enhancement feat XL Extra Large feature
Projects
None yet
2 participants