-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] stocks/fa/balance --plot
doesn't work after converting to K/M/B string notation
#3873
Comments
do you mean when the table contains Ms and Bs?
This is a limitation of prompt toolkit. We cannot dynamically change the auto complete options based on the previous output (without massively slowing down), so we defaulted to picking yf options as default |
Yeah it tries to plot strings which is most likely due to the Ms and the Bs. For the auto complete, I think it can help we have some generic naming in that case. Right now, many will also fail since they do not match properly. Let the ones that are available at least map to something for each data source. |
stocks/fa/balance --plot
doesn't work if the source contains Ms and Bsstocks/fa/balance --plot
doesn't work after converting to K/M/B string notation
This is not the case. The data output depends if one should plot or not, see following from the code base: df_fa = df_fa.iloc[:, 0:limit]
df_fa_c = clean_metrics_df(df_fa, num=limit)
return df_fa_c if not plot else df_fa
Note that we default to the options of the chosen default data source. |
* Fix plotting error I choose to fix it by removing the denomination transform, since it doesn't affect the result (even when fixed). * Add generic naming to financial statements, except for EODHD source * Fix linting * Fix linting * Fix bugs * Fix linting * Handle invalid plot options for sources * Fix linting * Fix linting * Some tests * more tests --------- Co-authored-by: James Maslek <jmaslek11@gmail.com>
If this is the output:
You can not use any of the plotting arguments as it would complain about not being able to convert a string:
Furthermore, the options that
--plot
provides often do not match when you use a different source than Yahoo Finance.The text was updated successfully, but these errors were encountered: