Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing fails to deliver bug and resulting NaN values in dataframe bug #1956

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Jun 16, 2022

Description

Fixes #1904 where an HTTP 404 error was occurring due to bad .zip download links to the SEC website. There were a handful of .zip files with very slightly different links than the rest of the urls. An additional bug was found and fixed where when reading the csv from the zip file it could not convert NaN values to int.

ftd_2017-2022

Tested with the following which resulted in a yaml file rewrite:
pytest /Users/jamessimmons/Desktop/OpenBB/OpenBBTerminal/tests/openbb_terminal/stocks/dark_pool_shorts/test_sec_model.py --record-mode=rewrite

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the bug Fix bug label Jun 16, 2022
@simmonsj330 simmonsj330 requested review from Chavithra and jmaslek June 16, 2022 22:14
@simmonsj330 simmonsj330 self-assigned this Jun 16, 2022
@@ -132,5 +172,6 @@ def get_fails_to_deliver(

ftds_data = ftds_data[ftds_data["SETTLEMENT DATE"] > start]
ftds_data = ftds_data[ftds_data["SETTLEMENT DATE"] < end]
print(ftds_data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ghh=)

@DidierRLopes DidierRLopes merged commit 0c60d70 into OpenBB-finance:main Jun 20, 2022
@simmonsj330 simmonsj330 deleted the ftd_date_range_bug branch June 29, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
3 participants