Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the help menu whenever users move to a different menu #1968

Merged
merged 15 commits into from
Jun 22, 2022
Merged

Display the help menu whenever users move to a different menu #1968

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ced9d47
switch auto print_help on exits
montezdesousa Jun 20, 2022
9919e6f
display help when home called from home directory
montezdesousa Jun 20, 2022
32ff328
Merge branch 'main' into gstdev868
minhhoang1023 Jun 20, 2022
f2e6bc3
change in test to expect help cmd
montezdesousa Jun 21, 2022
308360d
change in test to expect help cmd
montezdesousa Jun 21, 2022
d823d72
sets autoexithelp flag on conftest
montezdesousa Jun 21, 2022
a7dc0d8
Merge branch 'gstdev868' of github.com:OpenBB-finance/OpenBBTerminal …
montezdesousa Jun 21, 2022
2b66abb
Merge branch 'main' into gstdev868
minhhoang1023 Jun 22, 2022
b58c802
supress help string print on quit
montezdesousa Jun 22, 2022
aa5f9fe
adapt tests to expect help
montezdesousa Jun 22, 2022
7eb7537
Merge branch 'gstdev868' of github.com:OpenBB-finance/OpenBBTerminal …
montezdesousa Jun 22, 2022
7986e32
adds help on 3 tests missing
montezdesousa Jun 22, 2022
08e8e95
run black
montezdesousa Jun 22, 2022
735e0f7
respect literal bool type
montezdesousa Jun 22, 2022
c03ec67
second attemp to respect literal bool
montezdesousa Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openbb_terminal/feature_flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
OPEN_REPORT_AS_HTML = strtobool(os.getenv("OPENBB_OPEN_REPORT_AS_HTML", "True"))

# Enable auto print_help when exiting menus
ENABLE_EXIT_AUTO_HELP = strtobool(os.getenv("OPENBB_ENABLE_EXIT_AUTO_HELP", "False"))
ENABLE_EXIT_AUTO_HELP = strtobool(os.getenv("OPENBB_ENABLE_EXIT_AUTO_HELP", "True"))

# Remember contexts during session
REMEMBER_CONTEXTS = strtobool(os.getenv("OPENBB_REMEMBER_CONTEXTS", "True"))
Expand Down
3 changes: 2 additions & 1 deletion openbb_terminal/parent_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,8 @@ def call_cls(self, _) -> None:
def call_home(self, _) -> None:
"""Process home command"""
self.save_class()
console.print("")
if self.PATH.count("/") == 1 and obbff.ENABLE_EXIT_AUTO_HELP:
self.print_help()
for _ in range(self.PATH.count("/") - 1):
self.queue.insert(0, "quit")

Expand Down