Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates a controller to specify sources #2069

Merged
merged 9 commits into from
Jul 12, 2022
Merged

Conversation

DidierRLopes
Copy link
Collaborator

Screenshot 2022-07-11 at 23 12 58

@DidierRLopes DidierRLopes added the feat S Small T-Shirt size Feature label Jul 11, 2022
@DidierRLopes DidierRLopes requested review from jmaslek and JerBouma July 11, 2022 22:13
@JerBouma
Copy link
Contributor

JerBouma commented Jul 12, 2022

Can't this be under the settings or featflags menu? I'd like to keep the Home menu small.

@DidierRLopes
Copy link
Collaborator Author

Can't this be under the settings or featflags menu? I'd like to keep the Home menu small.

This one is quite different from settings and featflags, and some users have been asking about this. So I would prefer to have it in it's own menu for more visibility :)

Copy link
Contributor

@JerBouma JerBouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of points.

Can't these either share the stocks/load structure or otherwise what we also use within Econometrics (stocks.load). This looks a bit odd.

image

Could you add some information within this menu how to set a different source? E.g. a text stating "Use get <command> to figure out what sources are available. Use set <command> -s <source> to alter the default source. E.g. set stocks_load -s iex"

@DidierRLopes
Copy link
Collaborator Author

Couple of points.

Can't these either share the stocks/load structure or otherwise what we also use within Econometrics (stocks.load). This looks a bit odd.

image

Could you add some information within this menu how to set a different source? E.g. a text stating "Use get <command> to figure out what sources are available. Use set <command> -s <source> to alter the default source. E.g. set stocks_load -s iex"

The "/" and the "." unfortunately break the auto-completer.

I improved the documentation when doing "-h"!

@DidierRLopes DidierRLopes merged commit 9e220e8 into main Jul 12, 2022
@colin99d colin99d deleted the sources-controller branch July 23, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants